Skip to content

Comments

Remove ModuleList component#2754

Merged
kasya merged 1 commit intomainfrom
clean-module-list
Nov 29, 2025
Merged

Remove ModuleList component#2754
kasya merged 1 commit intomainfrom
clean-module-list

Conversation

@kasya
Copy link
Collaborator

@kasya kasya commented Nov 29, 2025

Removed <ModuleList /> component and all references of it.

Checklist

  • I've read and followed the contributing guidelines.
  • I've run make check-test locally; all checks and tests passed.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 29, 2025 •
edited
Loading

Summary by CodeRabbit

  • Tests

    • Removed the complete unit test suite for the module list component, which previously covered toggle behavior, text truncation, and various edge cases.

  • Refactor

    • Removed the module list display feature from cards. Module information will no longer appear in the card interface.

✏️ Tip: You can customize this high-level summary in your review settings.

Walkthrough

The pull request removes the ModuleList component and all associated functionality from the frontend codebase. This includes deletion of the component file, its comprehensive test suite, removal of ModuleList imports and rendering from Card.tsx, and elimination of the modules prop from the CardProps type definition.

Changes

Cohort / File(s) Summary
ModuleList Component Removal
frontend/src/components/ModuleList.tsx, frontend/__tests__/unit/components/ModuleList.test.tsx		 Entire ModuleList component file deleted, including its rendering logic for module items as buttons with "Show More/Less" toggle and accessibility features. Accompanying comprehensive unit test suite deleted including mocks and test assertions for edge cases, truncation, and toggle functionality.
Card Component Updates
frontend/src/components/Card.tsx, frontend/src/types/card.ts		 Removed ModuleList import and rendering from Card.tsx. Removed modules prop (modules?: string[]) from CardProps type definition in card.ts. Card component no longer accepts or displays module lists.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify no other components in the codebase reference or import the deleted ModuleList component
  • Confirm that removal of the modules prop from CardProps does not break any consumer components passing this prop

Suggested labels

frontend, frontend-tests

Suggested reviewers

  • arkid15r

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Remove ModuleList component' directly and accurately describes the main change: the removal of the ModuleList component and all its references throughout the codebase.
Description check ✅ Passed The description clearly states the purpose of the PR: removal of the ModuleList component and all references to it, which aligns with the actual changes made across multiple files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch clean-module-list
📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ccf5817 and ef11cb3.

📒 Files selected for processing (4)
  • frontend/__tests__/unit/components/ModuleList.test.tsx (0 hunks)
  • frontend/src/components/Card.tsx (0 hunks)
  • frontend/src/components/ModuleList.tsx (0 hunks)
  • frontend/src/types/card.ts (0 hunks)
💤 Files with no reviewable changes (4)
  • frontend/src/components/Card.tsx
  • frontend/tests/unit/components/ModuleList.test.tsx
  • frontend/src/types/card.ts
  • frontend/src/components/ModuleList.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: Run frontend e2e tests
  • GitHub Check: Run backend tests
  • GitHub Check: Run frontend unit tests
  • GitHub Check: CodeQL (javascript-typescript)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 29, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@kasya kasya marked this pull request as ready for review November 29, 2025 19:21
@kasya kasya requested a review from arkid15r as a code owner November 29, 2025 19:21
@kasya kasya added this pull request to the merge queue Nov 29, 2025
Merged via the queue into main with commit 1dfdcf0 Nov 29, 2025
28 checks passed
@kasya kasya deleted the clean-module-list branch November 29, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arkid15r arkid15r arkid15r approved these changes

Assignees

No one assigned

Labels

frontend frontend-tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kasya @arkid15r